Add compat data for HTMLCanvasElement#880
Merged
Merged
Conversation
Elchi3
requested changes
Jan 22, 2018
Elchi3
left a comment
Member
There was a problem hiding this comment.
Well done, thanks!
Left some comments inline for you to fix.
| "deprecated": false | ||
| } | ||
| }, | ||
| "webgl context": { |
Member
There was a problem hiding this comment.
This and the following are not nested under getContext which seems to be missing.
| }, | ||
| "chrome": { | ||
| "version_added": "9", | ||
| "notes": "Chrome 9 and Firefox 3.6 initially implemented this as <code>experimental-webgl</code>. Since Chrome 33 and Firfox 24 it is implemented as the standard <code>webgl</code>." |
Member
There was a problem hiding this comment.
Please only talk about Chrome here, use version ranges, and the alternative_name property.
| }, | ||
| "edge": { | ||
| "version_added": true, | ||
| "notes": "Edge, Internet Explorer 11, WebKit 5.1 and Firefox Mobile implemented this as <code>experimental-webgl</code>." |
Member
There was a problem hiding this comment.
This could be alternative_name without a note.
| "firefox": [ | ||
| { | ||
| "version_added": "3.6", | ||
| "notes": "Chrome 9 and Firefox 3.6 initially implemented this as <code>experimental-webgl</code>. Since Chrome 33 and Firfox 24 it is implemented as the standard <code>webgl</code>." |
Member
There was a problem hiding this comment.
Please only talk about Firefox here, use version ranges, and the alternative_name property.
| ], | ||
| "firefox_android": { | ||
| "version_added": true, | ||
| "notes": "Edge, Internet Explorer 11, WebKit 5.1 and Firefox Mobile implemented this as <code>experimental-webgl</code>." |
Member
There was a problem hiding this comment.
This could be alternative_name without a note.
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": true |
| "status": { | ||
| "experimental": false, | ||
| "standard_track": true, | ||
| "deprecated": true |
| "status": { | ||
| "experimental": true, | ||
| "standard_track": false, | ||
| "deprecated": true |
| }, | ||
| "firefox": { | ||
| "version_added": "44", | ||
| "notes": "This feature is behind a feature preference setting. In about:config, set <code>gfx.offscreencanvas.enabled</code> to <code>true</code>." |
| }, | ||
| "firefox_android": { | ||
| "version_added": "4", | ||
| "notes": "This feature is behind a feature preference setting. In about:config, set <code>gfx.offscreencanvas.enabled</code> to <code>true</code>." |
Elchi3
requested changes
Jan 25, 2018
| ] | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": "4", |
| "deprecated": false | ||
| } | ||
| }, | ||
| "Image quality parameter": { |
Member
There was a problem hiding this comment.
No spaces in the identifier; please add a description.
Contributor
Author
|
done and done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.