IE11 doesn't support Map(iterable) constructor#874
Merged
Conversation
The data here claimed IE11 has partial support for Map(iterable) constructor when the iterable is an array, but kangx compat tables and repeatable tests contradict that claim. Test to verify: https://jsfiddle.net/rbew03rk/1/
|
This is related to a previous issue #691 where IE11 seemed to support accepting key/value pairs as a constructor. This doesn't seem to be the case anymore. |
Member
|
So, this is then just unsupported completely? In that case the PR should be: "ie": {
"version_added": false
}and not removing the |
|
After changing Yes to No, the note saying: "1. Only supports arrays of key/value pairs, such as new Map([ ['foo', 'bar'] ])." must also be removed too. |
Craga89
added a commit
to Craga89/popmotion
that referenced
this pull request
Sep 20, 2018
As [described here](mdn/browser-compat-data#874), IE11 does not support passing in an array of tuples to the `Map` constructor. Changed this to use a generic constructor and `set` call instead.
mattgperry
pushed a commit
to Popmotion/popmotion
that referenced
this pull request
Sep 21, 2018
* fix(IE11): Convert Map constructor to a set call As [described here](mdn/browser-compat-data#874), IE11 does not support passing in an array of tuples to the `Map` constructor. Changed this to use a generic constructor and `set` call instead. * Update default-transitions.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data here claimed IE11 has partial support for Map(iterable) constructor when the iterable is an array, but kangx compat tables and repeatable tests contradict that claim.
Test to verify: https://jsfiddle.net/rbew03rk/1/