Skip to content

Refactor browser data#834

Merged
teoli2003 merged 4 commits into
masterfrom
refactor-browsers
Jan 28, 2018
Merged

Refactor browser data#834
teoli2003 merged 4 commits into
masterfrom
refactor-browsers

Conversation

@Elchi3

@Elchi3 Elchi3 commented Jan 11, 2018

Copy link
Copy Markdown
Member

This does cleanup a few things, but it shouldn't be visible at all to data consumers.

  • Split up browsers.json into several files (one for each browser)
  • Move the schemas into a schemas/ folder
  • Adjust the docs and test scripts to work with the two changes above
  • Document the browser schema.

https://github.com/mdn/browser-compat-data/tree/refactor-browsers is the branch that shows the repo with the files moved around.

@Elchi3 Elchi3 added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label Jan 11, 2018
@Elchi3 Elchi3 requested a review from teoli2003 January 19, 2018 12:57

@teoli2003 teoli2003 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

@teoli2003 teoli2003 merged commit 6cf7a36 into master Jan 28, 2018
@Elchi3 Elchi3 deleted the refactor-browsers branch January 28, 2018 16:54
@Elchi3

Elchi3 commented Jan 28, 2018

Copy link
Copy Markdown
Member Author

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:browsers Data about browsers (versions, release dates, etc). This data is used for validation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants