SharedArrayBuffer now unsupported to mitigate Spectre attack#789
Merged
Conversation
Contributor
|
Looks good to me. :) |
jwhitlock
approved these changes
Jan 4, 2018
jwhitlock
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, but I didn't try it (relying on linting, Florian's expertise).
| }, | ||
| "safari": { | ||
| "version_added": "10.1" | ||
| "version_added": false |
Contributor
There was a problem hiding this comment.
Should this be false or a version_removed?
Member
Author
There was a problem hiding this comment.
I don't actually know the version this will be removed, so I thought it's best to just mark it false for now. It could be version_removed: true though. hmm...
| { | ||
| "version_added": "46", | ||
| "version_removed": "54", | ||
| "version_removed": "55", |
Contributor
There was a problem hiding this comment.
Should this be a separate entry, or combined with the "57" entry?
Member
Author
There was a problem hiding this comment.
I think to properly record the history here, it should be separate.
… unknown future version)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Atomics
Edge: https://blogs.windows.com/msedgedev/2018/01/03/speculative-execution-mitigations-microsoft-edge-internet-explorer/#Ok7vGAAIGwYwLQAf.97
Firefox: https://blog.mozilla.org/security/2018/01/03/mitigations-landing-new-class-timing-attack/
Chromium: https://www.chromium.org/Home/chromium-security/ssca
Safari: https://bugs.webkit.org/show_bug.cgi?id=181266