Skip to content

Firefox 59 allows browserAction set* methods to accept null#710

Merged
wbamberg merged 2 commits into
mdn:masterfrom
Loirooriol:patch-1
Dec 15, 2017
Merged

Firefox 59 allows browserAction set* methods to accept null#710
wbamberg merged 2 commits into
mdn:masterfrom
Loirooriol:patch-1

Conversation

@Loirooriol

Copy link
Copy Markdown
Contributor

@teoli2003 teoli2003 added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Dec 10, 2017
@wbamberg

Copy link
Copy Markdown
Contributor

Thanks for this, and sorry to be slow reviewing.

I think this is good, but it needs a description field: just null as a subfeature doesn't explain properly what the thing is.

The description could be something like (for example, for setTitle():

"The <code>title</code> property of the <code>details</code> parameter can be set to <code>null</code>."

@Loirooriol

Copy link
Copy Markdown
Contributor Author

Done! You can squash the commits into a single one, right?

@wbamberg wbamberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Loirooriol !

@wbamberg wbamberg merged commit 58573ed into mdn:master Dec 15, 2017
@Loirooriol Loirooriol deleted the patch-1 branch December 18, 2017 16:11
@Loirooriol

Copy link
Copy Markdown
Contributor Author

Will MDN be updated automatically or should I do something?

@wbamberg

Copy link
Copy Markdown
Contributor

Will MDN be updated automatically or should I do something?

Short answer: you don't have to do anything.

Long answer: after you update compat data, several things need to happen before the pages display the new data:

  1. the MDN team needs to make a new release of the npm package containing the data
  2. the MDN team needs to make a new production deployment that contains the new npm package
  3. someone needs to shift-refresh the page while logged into MDN, so the macros that build the table are regenerated.

(1) and (2) happen each week, usually Monday. So your change was actually deployed already. I just did (3), so the tables are now updated.

In 2018 we're planning to make this process simpler and faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants