chore: remove HTTPClientFactory, multipart helpers, and related tests from network package - #7023
Draft
sammaji wants to merge 1 commit into
Draft
chore: remove HTTPClientFactory, multipart helpers, and related tests from network package#7023sammaji wants to merge 1 commit into
sammaji wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sammaji
force-pushed
the
09-09-fix_remove_dead_code_from_networking_package
branch
2 times, most recently
from
September 9, 2026 10:05
e24308d to
a9994a9
Compare
sammaji
force-pushed
the
09-09-fix_remove_dead_code_from_networking_package
branch
from
September 9, 2026 10:08
a9994a9 to
5b99705
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
HTTPClientFactoryabstraction and all associated proxy-aware client management logic fromcore/network, along with themultipart.goutilities and their tests. This cleans up code that is no longer needed, reducing complexity in the network package.Changes
HTTPClientFactory, including its constructor,FactoryOptionpattern,GetFasthttpClient,GetHTTPClient,createFasthttpClient,createHTTPClient,configureFasthttpProxy,configureHTTPProxy,buildProxyURLWithAuth,UpdateProxyConfig,GetProxyConfig, andisProxyEnabledForPurposemethodsClientPurposetype and its constants (ClientPurposeSCIM,ClientPurposeInference,ClientPurposeAPI)multipart.goentirely, which containedParseMultipartFormFields,ReconstructMultipartBody,WriteMultipartField, andSerializePayloadToRequestshouldBypassProxy,dialAddrHost,StaleConnectionRetryIfErr,GlobalProxyConfig, andDefaultClientConfig, which remain in useType of change
Affected areas
How to test
go version go test ./...Verify that no remaining code references
HTTPClientFactory,ClientPurpose, or the removed multipart helpers, and that all existing tests pass.Screenshots/Recordings
N/A
Breaking changes
Any callers of
HTTPClientFactory,GetFasthttpClient,GetHTTPClient,ParseMultipartFormFields,ReconstructMultipartBody,WriteMultipartField, orSerializePayloadToRequestmust be updated to use alternative implementations, as these are no longer available in thenetworkpackage.Related issues
N/A
Security considerations
The removed proxy configuration logic included TLS skip-verify handling and proxy authentication. Ensure that any replacement implementations preserve the same TLS and authentication safeguards.
Checklist
docs/contributing/README.mdand followed the guidelines