Skip to content

Caching the results of Transform.transform_path for non-affine transforms #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelson merged 9 commits into from
Jun 8, 2012
Merged

Caching the results of Transform.transform_path for non-affine transforms #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
753c9a2
Single commit of necessary transform changes.
Feb 28, 2012
c4ceace
Fixed is_affine inheritance & added scatter test which highlighted th…
Mar 6, 2012
bf4dd97
Fixed failing unit test. (in test_axes)
Mar 6, 2012
4c88a6d
Moved scatter test into test_axes.py
Mar 20, 2012
c088477
Fixed broken handling of WrappedTransform
Apr 20, 2012
1b1b340
Intermediate commit to request some assistance.
Apr 20, 2012
e9cc98e
Fixed __array__ releated bug that I introduced.
May 1, 2012
c898bdf
Improved comments.
May 1, 2012
a81545c
Now working with rebased master.
pelson Jun 7, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/matplotlib/backends/backend_svg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,9 +657,9 @@ def draw_gouraud_triangle(self, gc, points, colors, trans):

writer.start(u'defs')
for i in range(3):
x1, y1 = points[i]
x2, y2 = points[(i + 1) % 3]
x3, y3 = points[(i + 2) % 3]
x1, y1 = tpoints[i]
Copy link
Member Author

@pelson pelson Jun 7, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug came out in the pcolor test (the pcolor was not in the correct place). I don't understand how it wasn't failing before, but the fact that the bug has been highlighted by this PR is a good sign.

x2, y2 = tpoints[(i + 1) % 3]
x3, y3 = tpoints[(i + 2) % 3]
c = colors[i][:]

if x2 == x3:
Expand Down
Binary file added lib/matplotlib/tests/baseline_images/test_axes/scatter.pdf
View file
Open in desktop
Binary file not shown.
Binary file added lib/matplotlib/tests/baseline_images/test_axes/scatter.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading