Skip to content

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Dec 12, 2024

PR summary

This is currently dropping scalable SVG symlinks, which breaks the toolbar on GTK.

Fixes #29229

PR checklist

@QuLogic QuLogic added Build CI: Run cibuildwheel Run wheel building tests on a PR labels Dec 12, 2024
@github-actions github-actions bot removed the CI: Run cibuildwheel Run wheel building tests on a PR label Dec 12, 2024
This is currently dropping scalable SVG symlinks, which breaks the
toolbar on GTK.
@QuLogic QuLogic added the CI: Run cibuildwheel Run wheel building tests on a PR label Dec 12, 2024
@QuLogic QuLogic added this to the v3.9.4 milestone Dec 12, 2024
@timhoffm
Copy link
Member

timhoffm commented Dec 12, 2024

Do we know what in meson 0.17 broke? Is there an upstream bug report? - I'm asking because thats the prerequisite for getting it fixed / unpinning in the future.

@QuLogic
Copy link
Member Author

QuLogic commented Dec 12, 2024

Yes, it arose from mesonbuild/meson-python#587; I am still investigating if there is a quick way to fix it on our side or whether it will need changes on their side.

@jklymak jklymak merged commit a23ef5a into matplotlib:main Dec 13, 2024
47 checks passed
@lumberbot-app
Copy link

lumberbot-app bot commented Dec 13, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.9.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 a23ef5a8176c08c7f3de4d1a78f9bf075554b2bd
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #29295: BLD: Pin meson-python to <0.17.0'
  1. Push to a named branch:
git push YOURFORK v3.9.x:auto-backport-of-pr-29295-on-v3.9.x
  1. Create a PR against branch v3.9.x, I would have named this PR:

"Backport PR #29295 on branch v3.9.x (BLD: Pin meson-python to <0.17.0)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 13, 2024
@QuLogic QuLogic deleted the pin-meson-python branch December 13, 2024 00:43
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Dec 13, 2024
QuLogic added a commit that referenced this pull request Dec 13, 2024
…3.9.x

Backport PR #29295 on branch v3.9.x (BLD: Pin meson-python to <0.17.0)
QuLogic added a commit that referenced this pull request Dec 13, 2024
…295-on-v3.10.x

Backport PR #29295 on branch v3.10.x (BLD: Pin meson-python to <0.17.0)
@QuLogic
Copy link
Member Author

QuLogic commented Dec 13, 2024

I've opened mesonbuild/meson-python#713 for meson-python upstream, and we can unpin once that is out in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build CI: Run cibuildwheel Run wheel building tests on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Icons do not work with GTK

3 participants