Skip to content

MAINT: Replace uses of tostring with tobytes #16958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timhoffm merged 1 commit into from
Mar 30, 2020
Merged

MAINT: Replace uses of tostring with tobytes #16958

timhoffm merged 1 commit into from
Mar 30, 2020

Conversation

@eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Mar 30, 2020

tostring() is the pre-numpy-1.9 name, and is not a good name in python3 where the return type is not str.

xref numpy/numpy#15867

@eric-wieser
MAINT: Replace uses of tostring with tobytes
93d45ec 
tostring() is the pre-numpy-1.9 name, and is not a good name in python3 where the return type is _not_ `str`.
anntzer
anntzer approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully ci passes :)

@timhoffm timhoffm added this to the v3.2.2 milestone Mar 30, 2020
@timhoffm timhoffm merged commit 2e8c0c7 into matplotlib:master Mar 30, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Mar 30, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 2e8c0c75f98d9f77cc8e17801ac77151083d1dc0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16958: MAINT: Replace uses of tostring with tobytes'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16958-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #16958 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@eric-wieser
Copy link
Contributor Author

eric-wieser commented Mar 30, 2020

Probably easier to manually backport with s/tostring\(/tobytes\(/g

@timhoffm timhoffm mentioned this pull request Apr 18, 2020
Merged
dstansby added a commit that referenced this pull request Apr 18, 2020
@dstansby
Merge pull request #17188 from timhoffm/backport-of-pr-16958-on-v3.2.x
5fc89c5 
Backport PR #16958: MAINT: Replace uses of tostring with tobytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@eric-wieser @anntzer @timhoffm