fix: Rearrange docker compose options - #327
Merged
mariotoffia merged 2 commits intoJul 25, 2025
Merged
Conversation
kosmakoff
marked this pull request as ready for review
July 22, 2025 15:38
Owner
|
Thanks for the PR @kosmakoff ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the lib doesn't quite work for me.
First: I have custom docker setup locally, and I have
DOCKER_HOSTenvironment variable. This variable is passed as-Hparameter to docker, but it does it in wrong place - as acomposeoption, instead it should be adockeroption.Second:
--project-directoryis a option ofcomposecommand, not ofcompose up, hence needed to be reordered, too.This PR fixes both these points.