Fixed primitive early return if all ref types are null#4005
Open
ronodhirSoumik wants to merge 1 commit intomapstruct:mainfrom
Open
Fixed primitive early return if all ref types are null#4005ronodhirSoumik wants to merge 1 commit intomapstruct:mainfrom
ronodhirSoumik wants to merge 1 commit intomapstruct:mainfrom
Conversation
Member
|
@ronodhirSoumik the CI is failing. Can you please fix it first and then I'll go ahead and review it |
5617f3a to
7cd00bd
Compare
Author
resolved |
Signed-off-by: ronodhirSoumik <ronodhirsoumik@gmail.com>
7cd00bd to
bccf903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3992
Updated the check in the ftl file to only generate an early return-null block if every single parameter is subject to a null check. If there are parameters that don't need null checks (like primitives), keep going and map them.