Color/MonoCamera frameEvent output, per-frame IR control#561
Merged
Conversation
|
When Testing this I had to invert the logic for choosing the dot and flood frames. |
|
@alex-luxonis Any idea when this will be reviewed and merged? |
themarpe
approved these changes
Jun 20, 2022
|
When this is merged, will that update the interfaces available in the depthai-core library? |
SzabolcsGergely
approved these changes
Aug 1, 2022
|
As per discord, I found that the turning off of the dot projector takes a bit of time, and if the autoexposure can pick up the tail end of this, so that you have dots in some of your images. Apart from disabling autoexposure, I found that if the projectors were switched off earlier then this was less of an issue. |
|
Hi @alex-luxonis @szabi-luxonis when will this be merged into main? Its just I received a new OAK-D Pro Partno A00565 and It doesn't work with this branch anymore. Doesn't recognise calibration params and the mono cameras don't come up. Alternatively if you can update this branch that would help me. |
|
Alternatively which branch should I merge into the depth-ai core, which is the actual repo I am using. Is it main or development? |
|
@alex-luxonis I think I will need help in identifying a correct device side commit for merging devlop into this branch. I am assuming that is from a non-open repository? |
Contributor
Author
|
@PeterQFR The branch was updated with the latest development, and a sync issue fixed in the example - commit above, by increasing the number of frames in the pool. Could you check if any issue is still seen. Thanks! |
|
Hi @alex-luxonis I've pulled this code in however, I had an issue. Because Its taken me too long to test this, I wasn't able to test against the ir_frame_develop branch as it had been deleted. so this is from a merge from develop commit a78ea3bac1695254c02b5ee066ba3c3312b8367e in depthai-core |
Contributor
Author
|
Hi @PeterQFR , could you try on the latest release |
|
Will do thanks |
|
@alex-luxonis did go though the local install of a wheel of the depthai-python but it failed with The full compile fail output: |
Contributor
Author
|
That happens rarely, usually it's solved by clearing the Hunter package manager cache: Possible also to install the prebuilt with one of:
(the latest 2.19.1.0 prebuilt wasn't available at the time I wrote before, due to a CI job failure, it was fixed by retriggering the run) |
|
That works. So I will raise another issue to focus on issue with the rgb link. It is something introduced, as when I revert back to my original older configuration for depthai-core, the system works. As an aside why do you install hunter in the home directory as a hidden file instead of installing in the build directory. Makes it easier to clean and know where all the dependencies are. |
Collaborator
@PeterQFR as its cached across different projects, additional builds, etc... - although given some complications that'd likely make more sense usually. Note to do so you can set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See description on related PR: luxonis/depthai-core#451
Added
MonoCamera/mono_preview_alternate_pro.pyexample: using a Script node on-device for controlling the IR projector and routing the frames to separate output pairs:dotL+dotRandfloodL+floodR.