perf: reduce snapshot read memory retention#985
Merged
Conversation
Contributor
WASM Size Report
|
65d6c6e to
6f0cbaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toJSONandloro-mirrorstyle reads.Measurements
Using the 32 MB fixture probe after exporting/importing a snapshot:
toJSON()then dropping JSON: 41.81 MB -> 25.58 MBTradeoff: repeated full read-only traversals decode again instead of reusing retained decoded values. Current release probe timings were roughly
toJSON72 ms, mirror shallow 79/59 ms, and mirror schema root 143/131 ms.Validation
cargo check -p loro-internalcargo test -p loro-internal handler --libcargo test -p loro-internal map --libcargo test -p loro-internal list --libcargo test -p loro-internal snapshot --libcargo test -p loro-internal richtext --libgit diff --check