pkglib/git: remove trailing spaces of GOPKGVERSION#4164
Merged
deitch merged 1 commit intolinuxkit:masterfrom Aug 29, 2025
Merged
pkglib/git: remove trailing spaces of GOPKGVERSION#4164deitch merged 1 commit intolinuxkit:masterfrom
deitch merged 1 commit intolinuxkit:masterfrom
Conversation
Collaborator
|
I am not sure I agree with this. If I say "dry run", and it finds it in the cache, then it is telling what it would build: nothing. If you would force a build, then |
Contributor
Author
|
this makes `--dry-run` inconvenient as it includes a newline Signed-off-by: Christoph Ostarek <christoph@zededa.com>
26c77a0 to
0185465
Compare
deitch
approved these changes
Aug 29, 2025
Collaborator
|
LGTM. Unfortunately, we need CI to run before merging, which can take a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this makes
--dry-runinconvenient as it includes a newline- What I did
trimming all whitespaces around the GOPKGVERSION
- How I did it
- How to verify it
Run
check that after
--build-arg=GOPKGVERSION=v0.0.0-20250828163257-a2e7a9467df0there is no newline- Description for the changelog
Fix trailing newline after GOPKGVERSION
- A picture of a cute animal (not mandatory but encouraged)