Merged
Conversation
Signed-off-by: Avi Deitcher <avi@deitcher.net>
70d3741 to
27bc67f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added a --dry-run option to
lkt pkg build, the same way we have one forlkt build, which reports thedocker buildcommand equivalent.It is not 100% correct or as useful as the
lkt buildone, for a few reasons:docker buildcommandslkt pkg builddoes not actually dodocker build, but rather uses buildkit with a container as a driver. You cannot really replicate that simply with a single command-lineBut it is a good start.
- How I did it
Added another
dockerRunnerimplementation that is dryrun.- How to verify it
Run it manually. This does not need testing, just that there are no regressions, for which CI is good enough.
- Description for the changelog
pkg build --dry-run