pkg build: handle race condition where builder is started at same time#4127
Merged
deitch merged 1 commit intolinuxkit:masterfrom Jun 25, 2025
Merged
pkg build: handle race condition where builder is started at same time#4127deitch merged 1 commit intolinuxkit:masterfrom
deitch merged 1 commit intolinuxkit:masterfrom
Conversation
Signed-off-by: Avi Deitcher <avi@deitcher.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
If two lkt processes attempt to create a builder container at the same time, they both do an inspect, it fails, so they both try to create. The first one succeeds, the second one gets a name conflict and fails. Handle that situation.
- How I did it
Add a retry loop. After a create fails, try it again after one second, up to 3 times.
- How to verify it
I did it manually by stopping the code right before the "create" clause, started a second process, let it create, and then continued the first. Before this it failed, with this it works. And, of course, CI will catch regressions.
- Description for the changelog
Handle builder container process starting in parallel.