Skip to content

draft: feat(import): add clickup import - #220

Closed
de-ar wants to merge 3 commits into
linear:masterfrom
de-ar:master
Closed

draft: feat(import): add clickup import#220
de-ar wants to merge 3 commits into
linear:masterfrom
de-ar:master

Conversation

@de-ar

@de-ar de-ar commented Oct 10, 2022

Copy link
Copy Markdown

No description provided.

@changeset-bot

changeset-bot Bot commented Oct 10, 2022 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f8b0c5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@de-ar de-ar mentioned this pull request Oct 10, 2022
Closed
@robcurtis

robcurtis commented Feb 11, 2023

Copy link
Copy Markdown

Is this PR getting merged soon? We're interested in moving over from Clickup.

@de-ar

de-ar commented Feb 11, 2023

Copy link
Copy Markdown
Author

Earlier I could not test the ClickUp importer. Right now, I'm busy at some other work. So no chance of it being merged anytime soon.

@Chew

Chew commented Jun 15, 2023

Copy link
Copy Markdown

Is there any updates, or do you intend to make some? I'd love to take over otherwise (will credit you as the starting point)

@de-ar

de-ar commented Jun 15, 2023

Copy link
Copy Markdown
Author

Hey @Chew!
I do intend to make updates, but my time has become limited. Please do take over and I'm here if you have any questions at all.

@Chew Chew mentioned this pull request Jun 15, 2023
Closed
akashchouhan16
akashchouhan16 suggested changes Jun 27, 2023
View reviewed changes
Comment thread package.json
{
"name": "linear",
"private": true,
"author": "Linear Orbit, Inc",

@akashchouhan16 akashchouhan16 Jun 27, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change on this line is not relevant to the PR, could keep it as it was previously.

Comment thread package.json
"build:import": "lerna run build:import",
"build:sdk": "lerna run build:sdk",
"build:types": "npx tsc --project tsconfig.check.json",
"build": "run-s generate build:sdk generate:test build:import build:types docs",

@akashchouhan16 akashchouhan16 Jun 27, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise for this line too. Not relevant to the proposed change in this PR.

Comment thread packages/import/package.json
"bin": {
"linear-import": "bin/linear-import.js"
},
"repository": "https://github.com/linear/linear",

@akashchouhan16 akashchouhan16 Jun 27, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a relevant code change

Comment thread packages/import/src/importers/clickupCsv/ClickupCsvImporter.ts
Medium: 3,
Low: 4,
};
return priorityMap[input] || 0;

@akashchouhan16 akashchouhan16 Jun 27, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ⚡

@de-ar de-ar closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@akashchouhan16 akashchouhan16 akashchouhan16 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@de-ar @robcurtis @Chew @akashchouhan16