make diff of blob to blob in repository.diff work#508
Merged
jdavid merged 2 commits intolibgit2:masterfrom Apr 3, 2015
Merged
Conversation
repository.diff work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I usually do
blob1.diff(blob2)but I ran into this the other day and I figured I might as well just fix it. That said, it's not clear to me it's a good idea to have two different ways of doing (what seems to be) the same thing (i.e.,blob1.diff(blob2)andrepo.diff(blob1, blob2)) but I leave that up to you. (The other alternative is to haverepo.diffbe only for showing changes between WT, index, and head)