Merged
Conversation
It is not possible to know how we can free the results of this allocation, so we shouldn't be using this function. We have a convention of returning Oid objects in pygit2, so let's keep to that in these places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not possible to know how we can free the results of this
allocation, so we shouldn't be using this function.
We have a convention of returning Oid objects in pygit2, so let's keep
to that in these places.
The tests showed some issues if we just leave it to use
strorreprto compare, though it likely won't affect anybody who is using this to print them out. So this may be a breaking change in certain situations.