Allow passing of Branch objects to Repository.checkout()#408
Merged
jdavid merged 2 commits intolibgit2:masterfrom Aug 26, 2014
djmattyg007:branches_are_references
Merged
Allow passing of Branch objects to Repository.checkout()#408jdavid merged 2 commits intolibgit2:masterfrom djmattyg007:branches_are_references
jdavid merged 2 commits intolibgit2:masterfrom
djmattyg007:branches_are_references
Conversation
Branch inherits from Reference, so there's no reason why we shouldn't be able to pass a Branch object.
This differs from the only other test which uses a Reference object. This test only succeeds because of the previous commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Repository.checkout() method checks to see if the refname
parameter is a Reference object with the following check:
This does not allow subclasses of Reference (such as Branch) to be used.
This pull request remedies this issue by changing the check to use
instanceof(), like so:
This pull request also adds a new test for this functionality.