oid: do not load the object when expanding#397
Merged
jdavid merged 1 commit intolibgit2:masterfrom Jul 28, 2014
Merged
Conversation
We now have a function which lets us expand an id prefix by checking for existence and uniqueness instead of loading the object with that id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have a function which lets us expand an id prefix by checking for
existence and uniqueness instead of loading the object with that id.
Ofen we're going to load the object immediately after so the difference would end up being a shift in where we spend the time loading it, but I think it's still worth trying to avoid work where it doesn't belong.