Blob: implement the memory buffer interface#362
Merged
jdavid merged 1 commit intolibgit2:masterfrom Apr 23, 2014
Merged
Conversation
This allows us to expose access to the blob's data without the need to copy it into new buffer.
Member
|
+1 to promote the efficient way. There is still Only concern is Let's do this for now:
I am going to merge this and change the README file accordingly. |
Member
|
Okey, the new support policy for Python 2.6 could read something like: (It looks like our support for Windows I would say...) |
Member
Author
|
Sounds good. We might be able to expose a method that calls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to expose access to the blob's data without the need to
copy it into new buffer.
Should we take
Blob.dataand make it return amemoryviewof the data instead of creating two ways o accessing it? I'm not too familiar with any differences in how you might want to use a PyBytes vs a memoryview.