Merged
Conversation
It claims you need to checkout a branch after clone, which is not the case currently (the clone function will do it for you). While here, format the docstring for sphinx to make it pretty.
The docs say to use tp_free() to free the memory, and even though we use PyObject_Del() everywhere else, using this in the credentials does cause issues.
Instead of making everyone inherit from our credential types, use an interface with two attributes, which makes the C code much shorter and simpler.
This was referenced Mar 28, 2014
Closed
|
I cloned the latest release: pygit-0.23.3
I tried:
Get: Question: |
|
@remusvrm The documentation isn't very clear, but what you need to do is: callbacks = pygit2.RemoteCallbacks(credentials = cred)
pygit2.clone_repositry(url, path, callbacks = callbacks) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for username/password and ssh keypair credentials. Add support for them in the Remote as well as
clone_repository(). The parameters expect a callback, but the provided types already provide the right__call__interface.There's a bit of sausage-making in this PR, with a bunch of code being removed in the middle, but I've kept it to show the process by which I arrived at this design.
Credentials implement two attributes, and the pygit2 code extracts the information from a tuple and passes it on to libgit2.