Add windows/arm64 to release binaries - #4218
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sAchin-680 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @sAchin-680! |
|
Hi @sAchin-680. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks @sAchin-680. In case you didn't notice it in the set of bot posts, you need to update the commit text to remove the "Fixes" line from there. The Kubernetes policy is to not include those in the commit itself because it can cause issues with cherry-picks, so only the PR description should include the special tag for issue linkage. You will need to amend the existing commit and force push the update to your branch. That will automatically refresh the PR and we can then proceed with reviews. |
Windows on ARM64 works with kind via `go install` already; this adds kind-windows-arm64 to the cross-compiled release binaries and updates install docs accordingly. Signed-off-by: sAchin-680 <mrmister680@gmail.com>
07121b0 to
95f0666
Compare
|
Thanks @stmcginnis !! I'll remove the |
go install sigs.k8s.io/kind@latestalready works on Windows ARM64 (confirmed in #3999), so this addskind-windows-arm64to the cross-compiled release binaries alongside the existing amd64 build, and updates the install docs (README, quick-start guide, RELEASE.md) accordingly.Fixes #3999