Skip to content

feat: Enable declarative validation for Service #135743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ahmed-kamal2004 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Enable declarative validation for Service #135743

ahmed-kamal2004 wants to merge 2 commits into from
+183 −4

Conversation

@ahmed-kamal2004
Copy link

@ahmed-kamal2004 ahmed-kamal2004 commented Dec 13, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Enables declarative validation for Service, by changing the pkg/registry/core/service/strategy.go and using rest.ValidateDeclarativelyWithMigrationChecks in svcStrategy.Validate, svcStrategy.ValidateUpdate, and serviceStatusStrategy.ValidateUpdate
  • Add declarative validation tests to pkg/registry/core/service/declarative_validation_test.go

Which issue(s) this PR is related to:

part of #134280

Special notes for your reviewer:

I believe the current hand-written validation logic for the Service is more complex than the current declarative validation tags, so complete migration to declarative validation for Service validation may need the creation of some more tags.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2025

Please note that we're already in Code Freeze for the upcoming v1.35.0 release.

Adding the milestone to this PR is strictly prohibited without proper approval. If this PR needs to be included in the v1.35.0 release:

  1. Technical review: get the PR reviewed and approved as usual (/lgtm and /approve)
  2. Inclusion in release: ping @sig-release-leads on the #sig-release Slack channel and suggest to add the v1.35.0 milestone to the PR

We're also in Test Freeze for the release-1.35 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.35.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Dec 13 15:49:26 UTC 2025.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 13, 2025 •
edited
Loading

CLA Signed
The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2025

Welcome @ahmed-kamal2004!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2025

Hi @ahmed-kamal2004. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 13, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahmed-kamal2004
Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 13, 2025
@ahmed-kamal2004
Copy link
Author

ahmed-kamal2004 commented Dec 13, 2025

/kind feature
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 13, 2025
@ahmed-kamal2004
Copy link
Author

ahmed-kamal2004 commented Dec 13, 2025 •
edited
Loading

/cc @aaron-prindle @yongruilin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@thockin thockin Awaiting requested review from thockin

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

@lalitc375 lalitc375 Awaiting requested review from lalitc375

@yongruilin yongruilin Awaiting requested review from yongruilin

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahmed-kamal2004 @k8s-ci-robot