pkg/scheduler: remove duplicated "pod" key in scheduler logging #135734
Conversation
Now that the pod is added to the context with klog.LoggerWithValues at the beginning of the scheduling cycle, passing the redundant "pod", klog.KObj(pod) key-value pair in every log line is no longer necessary. This change removes all remaining duplicated "pod" keys in pkg/scheduler to fully migrate to contextual logging. This is part of the ongoing effort to adopt contextual logging in the scheduler (KEP-3071).
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Please note that we're already in Code Freeze for the upcoming v1.35.0 release. Adding the milestone to this PR is strictly prohibited without proper approval. If this PR needs to be included in the v1.35.0 release:
We're also in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Dec 12 03:41:12 UTC 2025. |
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AutuSnow The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @AutuSnow. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 6d5b5f215e9e23c5418d987efa2fdc0e8dc1dfe9
|
|
@AutuSnow: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
pkg/scheduler: remove duplicated "pod" key in scheduler logging
Now that the pod is added to the context with klog.LoggerWithValues
at the beginning of the scheduling cycle, passing the redundant
"pod", klog.KObj(pod) key-value pair in every log line is no longer
necessary.
This change removes the remaining duplicated "pod" keys in
pkg/scheduler/scheduler.go to complete the migration to contextual logging.
This is part of the ongoing effort to adopt contextual logging in the
scheduler (KEP-3071).
/kind cleanup
Signed-off-by: Liu Yutao liuyutao36@gmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Completes the contextual logging migration by removing ~17 duplicated "pod" log keys.
No functional changes.
Which issue(s) this PR is related to:
Related to #111672
Part of KEP-3071
Does this PR introduce a user-facing change?