Update display_ssd1309_oled_128x64_i2c.py - #1538

Thanks for the PR. Did you verify this still works if the font doesn't exist at the specified location?

Thanks for the PR. Did you verify this still works if the font doesn't exist at the specified location?

No, it will fail. I added the font to the list of dependencies; dpkg -L specifies that path as a standard. If they change something in the upcoming releases, it will break.

I can add some error handling around it, like:

from PIL import ImageFont

font_path = "/usr/share/fonts/truetype/dejavu/DejaVuSansMono/DejaVuSansMono.ttf"
font_size = 9

try:
    # Attempt to load the preferred font
    self.font = ImageFont.truetype(font_path, font_size)
except (IOError, OSError) as e:
    # Log the issue directly to the Mycodo log system
    self.logger.warning(f"Could not load custom font at {font_path} ({e}). Falling back to default font.")
    # Fallback to ensure the display still functions
    self.font = ImageFont.load_default()

LMK if this is acceptable, and I'll update the PR.

Also, libfreetype and libtiff6 are statically linked in Pillow and probably not required here so can be dropped.

I think having either a try/except or os.path.isfile() check would be good, as we can't expect every system to function as we expect, so should have a safe fallback.

As for the dependencies, I can't recall why they were included, but often they're added because at some time in the past when the module was made, they may have been required to be installed.

I also forgot to mention, the Pillow dependency should be pegged to a version, specifically the version all the other modules use. Otherwise, the version will be changed whenever someone installs another module with the other version of Pillow specified. This goes for any pip package that is used by more than one module.

Hi Kyle,
I fixed that but then I got a little carried away and tried to utilize the full size of the screen. Right now it looks like this, with configurable thresholds for "Alarm state" and "Alarm" shown when there are no measurements, i.e. sensor disconnected. They also blink on screen refresh. Units and age are also configurable and can be hidden by a checkbox flag.

Let me know if you want this in the same PR, or if I should create a separate PR or even a separate display function for this.

Does an upgrade break functionality for current users? If so, then it would be more appropriate as a separate module.