Skip replacing the embed markup on AMP pages - #54
Merged
kevinweber merged 2 commits intoMar 27, 2021
Conversation
kevinweber
reviewed
Mar 23, 2021
| } | ||
|
|
||
| $isAmp = function_exists('amp_is_request') && amp_is_request(); | ||
|
|
Owner
There was a problem hiding this comment.
@mjaschen Thank you for the contribution, very much appreciated!
This is maybe a bit nit-picky but we can make the code a little bit more readable by using an early return instead of having !$isAmp && (! is_feed()) in two conditions:
$isAmp = function_exists('amp_is_request') && amp_is_request();
if ($isAmp || is_feed()) return $return;What do you think?
Either way, I'll get to merging and publishing this change on the upcoming weekend.
Thanks again for contributing!
Contributor
Author
|
Hi @kevinweber you're absolutely right. I've updated the checks and added early returns. |
kevinweber
approved these changes
Mar 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the “AMP for WordPress” plugin, the
<noscript>message is shown („Video can't be loaded because JavaScript is disabled“).This pull request checks if the current request is for an AMP page and skips replacing the embed markup in this case.