kata-deploy: remove containerd handlers a redeploy drops - #13810
Draft
fidencio wants to merge 2 commits into
Draft
kata-deploy: remove containerd handlers a redeploy drops#13810fidencio wants to merge 2 commits into
fidencio wants to merge 2 commits into
Conversation
configure_containerd only ever added handlers, so turning a variant off left its stanza behind naming the configuration the same redeploy had deleted. The node kept advertising the handler and pods on it hung in ContainerCreating. Reconcile instead: drop every stanza under this installation's dest_dir that the current configuration did not just write, and its runtime_platforms entry in the CRI images plugin. Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Fabiano Fidêncio <ffidencio@nvidia.com>
Toggle debug off against a live cluster and assert the handler leaves the containerd configuration and node.status.runtimeHandlers with its RuntimeClass, while the base shim keeps running pods. Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Fabiano Fidêncio <ffidencio@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure_containerd only ever added handlers, so turning a variant off left its stanza behind naming the configuration the same redeploy had deleted. The node kept advertising the handler and pods on it hung in ContainerCreating.
Reconcile instead: drop every stanza under this installation's dest_dir that the current configuration did not just write, and its
runtime_platforms entry in the CRI images plugin.