Make it possible to enable Gutenberg editor for custom post types#43
Merged
aprokopenko merged 2 commits intojustcoded:masterfrom Jan 14, 2019
Merged
Make it possible to enable Gutenberg editor for custom post types#43aprokopenko merged 2 commits intojustcoded:masterfrom
aprokopenko merged 2 commits intojustcoded:masterfrom
Conversation
Collaborator
|
Thanks for contributing. Will check it as soon as I have some time. |
Collaborator
|
Quick question: Why you want to add special property, if it just add standard "editor" support key? I suggest to add property for show in rest, and remove gutenberg property, because it duplicates support property key (and we have constant for that). Please let me know your thoughts and update code a bit. |
…vious that we add support for gutenberg
Contributor
Author
|
@aprokopenko I like your suggestion, changed it accordingly 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since WordPress 5.0 is released I think it is good to add at least optional support for Gutenberg in custom post types.