Skip to content

Altered equalTo selector to find compare element in same form #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bramstroker wants to merge 1 commit into from
Closed

Altered equalTo selector to find compare element in same form #667

bramstroker wants to merge 1 commit into from

Conversation

@bramstroker
Copy link

@bramstroker bramstroker commented Mar 1, 2013

equalTo validator will fail when I have 2 forms containing the target element with the same name.

i.e.

<form id="test1" name="test1">
    <input type="text" name="somefield" />
    <input type="text" name="somefield_again" />
</form>
<form id="test2" name="test2">
    <input type="text" name="somefield" />
    <input type="text" name="somefield_again" />
</form>

And my rules:

$('#test2').validate({
    rules : {
         somefield_again : {
             equalTo : "[name='somefield']"
         }
    }
});

This would fail in the second form, because somefield_again from form test2 will be compared to somefield of test1.

@bramstroker bramstroker mentioned this pull request Mar 1, 2013
Merged
@bramstroker
Copy link
Author

bramstroker commented Mar 2, 2013

This PR seems a duplicate of #637. It is implemented in a much cleaner way in the other PR so I'll close this one.

@bramstroker bramstroker closed this Mar 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bramstroker