mobile number for Russia Federation #2207

jehadja · 2018-09-03T01:15:57Z

Description

Thank you!

Arkni · 2018-09-30T12:48:33Z

Thanks for your contribution! I'll triage and take a look at it as soon as possible!

Arkni

Thanks for your contribution.

Overall, it looks good. Only 2 changes are needed + a test case to be added and we are good to go.
For the test case, you can inspire from mobileUK test:

jquery-validation/test/methods.js

Lines 850 to 869 in 3a7e593

 QUnit.test( "mobileUK", function( assert ) { 

 var method = methodTest( "mobileUK" ); 

 assert.ok( method( "07134234323" ), "Valid UK Mobile Number" ); 

 assert.ok( method( "07334234323" ), "Valid UK Mobile Number" ); 

 assert.ok( method( "07624234323" ), "Valid UK Mobile Number" ); 

 assert.ok( method( "07734234323" ), "Valid UK Mobile Number" ); 

 assert.ok( method( "+447134234323" ), "Valid UK Mobile Number" ); 

 assert.ok( method( "+447334234323" ), "Valid UK Mobile Number" ); 

 assert.ok( method( "+447624234323" ), "Valid UK Mobile Number" ); 

 assert.ok( method( "+447734234323" ), "Valid UK Mobile Number" ); 

 assert.ok( !method( "07034234323" ), "Invalid UK Mobile Number" ); 

 assert.ok( !method( "0753423432" ), "Invalid UK Mobile Number" ); 

 assert.ok( !method( "07604234323" ), "Invalid UK Mobile Number" ); 

 assert.ok( !method( "077342343234" ), "Invalid UK Mobile Number" ); 

 assert.ok( !method( "044342343234" ), "Invalid UK Mobile Number" ); 

 assert.ok( !method( "+44753423432" ), "Invalid UK Mobile Number" ); 

 assert.ok( !method( "+447604234323" ), "Invalid UK Mobile Number" ); 

 assert.ok( !method( "+4477342343234" ), "Invalid UK Mobile Number" ); 

 assert.ok( !method( "+4444342343234" ), "Invalid UK Mobile Number" ); 

 } );

You can add your tests to the same file.

Thanks!

Arkni · 2018-10-06T11:23:16Z

src/additional/mobileRU.js

@@ -0,0 +1,6 @@
+/*  mobile number for Russia Fedaration */
+$.validator.addMethod( "mobileRU", function( phone_number, element ) {
+	phone_number = phone_number.replace( /\(|\)|\s+|-/g, "" );


Please create a new variable phoneNumber or something else and assign the result to it.

Arkni · 2018-10-06T11:27:11Z

src/additional/mobileRU.js

+$.validator.addMethod( "mobileRU", function( phone_number, element ) {
+	phone_number = phone_number.replace( /\(|\)|\s+|-/g, "" );
+	return this.optional( element ) || phone_number.length > 9 &&
+		phone_number.match( /^((\+7|7|8)+([0-9]){10})$/ );


Please use regex.test instead of string.match. We only need to know whether the string matches the regex or not.
phone_number.match( /^((\+7|7|8)+([0-9]){10})$/ ) => /^((\+7|7|8)+([0-9]){10})$/.test( phone_number )

Arkni

LGTM 👍

Thanks a lot for working on this :)

mobile number for Russia Fedaration

5eb121b

Arkni added Additional Methods NEEDS REVIEW labels Sep 30, 2018

Arkni requested changes Oct 6, 2018

View reviewed changes

Arkni added the NEEDS TEST label Oct 6, 2018

jehadja and others added 5 commits October 28, 2018 02:44

Update mobileRU.js

84e1a69

Update mobileRU.js

0b9d865

Update mobileRU.js

3ca0515

Update methods.js

8aad44d

Fix indentation issue

44159e7

Arkni removed NEEDS REVIEW NEEDS TEST labels Nov 6, 2018

Arkni approved these changes Nov 6, 2018

View reviewed changes

Arkni merged commit 3242f0f into jquery-validation:master Nov 6, 2018

vpetersson mentioned this pull request Mar 17, 2020

[Snyk] Upgrade jquery-validation from 1.19.0 to 1.19.1 WoTTsecurity/api#795

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

mobile number for Russia Federation #2207

mobile number for Russia Federation #2207

Uh oh!

jehadja commented Sep 3, 2018

Uh oh!

Arkni commented Sep 30, 2018

Uh oh!

Arkni left a comment

Uh oh!

Arkni Oct 6, 2018

Uh oh!

Arkni Oct 6, 2018

Uh oh!

Arkni left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	QUnit.test( "mobileUK", function( assert ) {
	var method = methodTest( "mobileUK" );
	assert.ok( method( "07134234323" ), "Valid UK Mobile Number" );
	assert.ok( method( "07334234323" ), "Valid UK Mobile Number" );
	assert.ok( method( "07624234323" ), "Valid UK Mobile Number" );
	assert.ok( method( "07734234323" ), "Valid UK Mobile Number" );
	assert.ok( method( "+447134234323" ), "Valid UK Mobile Number" );
	assert.ok( method( "+447334234323" ), "Valid UK Mobile Number" );
	assert.ok( method( "+447624234323" ), "Valid UK Mobile Number" );
	assert.ok( method( "+447734234323" ), "Valid UK Mobile Number" );
	assert.ok( !method( "07034234323" ), "Invalid UK Mobile Number" );
	assert.ok( !method( "0753423432" ), "Invalid UK Mobile Number" );
	assert.ok( !method( "07604234323" ), "Invalid UK Mobile Number" );
	assert.ok( !method( "077342343234" ), "Invalid UK Mobile Number" );
	assert.ok( !method( "044342343234" ), "Invalid UK Mobile Number" );
	assert.ok( !method( "+44753423432" ), "Invalid UK Mobile Number" );
	assert.ok( !method( "+447604234323" ), "Invalid UK Mobile Number" );
	assert.ok( !method( "+4477342343234" ), "Invalid UK Mobile Number" );
	assert.ok( !method( "+4444342343234" ), "Invalid UK Mobile Number" );
	} );

Uh oh!

mobile number for Russia Federation #2207

mobile number for Russia Federation #2207

Uh oh!

Conversation

jehadja commented Sep 3, 2018

Description

Uh oh!

Arkni commented Sep 30, 2018

Uh oh!

Arkni left a comment

Choose a reason for hiding this comment

Uh oh!

Arkni Oct 6, 2018

Choose a reason for hiding this comment

Uh oh!

Arkni Oct 6, 2018

Choose a reason for hiding this comment

Uh oh!

Arkni left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants