bugfix: Evaluate actor lazily on pre-save hooks - #815
Open
john-wd wants to merge 2 commits into
Open
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #815 +/- ##
=======================================
Coverage 96.33% 96.34%
=======================================
Files 35 35
Lines 1256 1257 +1
=======================================
+ Hits 1210 1211 +1
Misses 46 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Nice, thanks. So let's merge it, or? ;d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #115
The issue reported is just an evaluation time problem; some auth libraries (like JWT auth and perhaps even on rest_framework) evaluates authentication lazily at view dispatch time, so auditlog sets the AnonymousUser in the auditlog pre-save closures, which is not right.
Use Django's own SimpleLazyObject which acts like a variable and evaluates at access time, so the proper user is used.