Skip to content

Chart#11

Merged
steveoni merged 17 commits intomasterfrom
chart
Apr 25, 2021
Merged

Chart#11
steveoni merged 17 commits intomasterfrom
chart

Conversation

@geoffrey1330
Copy link
Member

No description provided.

export default function ChartsViz({chartComp}) {
export default function ChartsViz({chartComp,setChartComp}) {
const remover = (key) => {
setChartComp(chartComp.filter((el) => el.key !==key));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of filter use splice() to delete the chart component.


export default function DataTables({datacomp, setCompIndex, setSidePlane,setDataComp}) {
const remover = (keys) => {
setDataComp(datacomp.filter((el) => el.keys !==keys));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here instead of filter we can delete the element totally.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did filter so the component can be deleted individually

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand but this not removing the element from the component state. can you try creating multiple charts and see if the deleting will work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does

src/App.js Outdated

read_csv(url, {start: 0, end: 20}).then(df => {
read_csv("https://raw.githubusercontent.com/plotly/datasets/master/finance-charts-apple.csv", {start: 0, end: 20}).then(df => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this link and add back the default url as read_csv(URL) before pushing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be capital URL?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no the former variable before adding this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you resolve the error in the danfo js lib

README.md Outdated

![](exxample.png)

![](Capture.PNG)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ![](capture.PNG) from here add it to your pull request message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@geoffrey1330
Copy link
Member Author

Uploading Capture.PNG…

@steveoni steveoni merged commit bbbe2bb into master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants