Scripts: async, defer #229
Conversation
|
|
|
Hi @larissaiurk, Still available for this task? Please, let me know if you have not time, and I might be able to resolve it. Thanks, |
|
@peruibeloko, @jonnathan-ls, do you have time to see what is possible to do in relation to this pull request? |
| 1. Scripts can't see DOM elements below them, so they can't add handlers etc. | ||
| 2. If there's a bulky script at the top of the page, it "blocks the page". Users can't see the page content till it downloads and runs: | ||
| 1. Os scripts não conseguem ver os elementos da DOM abaixo deles, então não conseguem manipular eventos, etc. | ||
| 2. Se houver um script volumoso no topo da página, ele vai "bloqueia a página". Os usuários não podem ver o conteúdo da página até que ele faça o download e execute: |
There was a problem hiding this comment.
| 2. Se houver um script volumoso no topo da página, ele vai "bloqueia a página". Os usuários não podem ver o conteúdo da página até que ele faça o download e execute: | |
| 2. Se houver um script volumoso no topo da página, ele vai "bloquear a página". Os usuários não podem ver o conteúdo da página até que ele faça o download e execute: |
|
@peruibeloko, could you help to fix the conflicts, update, and approve it? |
During the review, I added simple adjustments (including the suggestion requested by @peruibeloko) and also conflict resolution @nazarepiedady /done |
nazarepiedady
left a comment
There was a problem hiding this comment.
It is good, but there are some little changes needed.
| Assim como `defer`, o atributo `async` é ignorado se a tag `<script>` não tiver `src`. | ||
| ``` | ||
| ## Dynamic scripts |
There was a problem hiding this comment.
It was not translated yet.
| ## Dynamic scripts | ||
| There's one more important way of adding a script to the page. |
There was a problem hiding this comment.
It also was not translated yet.
|
Please make the requested changes. After it, add a comment "/done". |
|
@jonnathan-ls, there are some changes that need to be translated. |
|
@nazarepiedady Thanks for watching, pending translation added /done |
nazarepiedady
left a comment
There was a problem hiding this comment.
It is good to be applied.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
No description provided.