Skip to content

change the default utf8 encoding #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oshai merged 1 commit into from
Apr 7, 2019
Merged

change the default utf8 encoding #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mysql-async/src/main/java/com/github/jasync/sql/db/mysql/util/CharsetMapper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class CharsetMapper(charsetsToIntComplement: Map<Charset, Int> = emptyMap()) {
const val Binary = 63

val DefaultCharsetsByCharset = mapOf(
CharsetUtil.UTF_8 to 83,
CharsetUtil.UTF_8 to Integer.getInteger("jasyncMysqlUTF8Collation", 224), //previous default was 83
CharsetUtil.US_ASCII to 65,
CharsetUtil.ISO_8859_1 to 69
)
Expand Down
18 changes: 18 additions & 0 deletions mysql-async/src/test/java/com/github/jasync/sql/db/mysql/QuerySpec.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,24 @@ class QuerySpec : ConnectionHelper() {

}

@Test
fun `test insert and query with unicode emoji`() {
val createTableEmoji = """CREATE TEMPORARY TABLE users (
id INT NOT NULL AUTO_INCREMENT ,
name VARCHAR(255) CHARACTER SET 'utf8mb4' NOT NULL ,
PRIMARY KEY (id) );"""
val insertEmoji = """INSERT INTO users (name) VALUES ('Boogie Man💩')"""
withConnection { connection ->
assertThat(executeQuery(connection, createTableEmoji).rowsAffected).isEqualTo(0)
assertThat(executeQuery(connection, insertEmoji).rowsAffected).isEqualTo(1)
val result: ResultSet = executeQuery(connection, this.select).rows

assertThat(result[0]("id")).isEqualTo(1)
assertThat(result(0)("name")).isEqualTo("""Boogie Man💩""")
}

}

@Test
fun `"connection" should "be able to select from a table" - validate columnNames()`() {

Expand Down