Skip to content

Backport Pdb closure evaluation fix (list comprehension, generators) from Python 3.13 #14933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krassowski merged 4 commits into from
Jul 1, 2025
Merged

Backport Pdb closure evaluation fix (list comprehension, generators) from Python 3.13 #14933

krassowski merged 4 commits into from
Jul 1, 2025

Conversation

@krassowski
Copy link
Member

@krassowski krassowski commented Jun 30, 2025 •
edited
Loading

image

Context

IPython already includes bits of Pdb code from Python itself, as documented in:

ipython/IPython/core/debugger.py

Lines 92 to 110 in 1e9a2e8

License
-------
Modified from the standard pdb.Pdb class to avoid including readline, so that
the command line completion of other programs which include this isn't
damaged.
In the future, this class will be expanded with improvements over the standard
pdb.
The original code in this file is mainly lifted out of cmd.py in Python 2.2,
with minor changes. Licensing should therefore be under the standard Python
terms. For details on the PSF (Python Software Foundation) standard license,
see:
https://docs.python.org/2/license.html
All the changes since then are under the same license as IPython.

I am taking a more cautious approach and separating the backport to a new file to make it easy to delete in the (near) future (1 year from now).

@krassowski krassowski added this to the 9.4 milestone Jun 30, 2025
@krassowski
Copy link
Member Author

krassowski commented Jun 30, 2025

We could use the same approach (_exec_in_closure) to solve #62 altogether, but that will need more testing - we could do so in a follow-up PR..

@krassowski krassowski marked this pull request as ready for review June 30, 2025 23:01
@krassowski krassowski merged commit 2197228 into ipython:main Jul 1, 2025
17 of 18 checks passed
@krassowski krassowski deleted the pdb-closure-fix-backport branch July 1, 2025 08:04
@krassowski krassowski mentioned this pull request Jul 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

9.4

Development

Successfully merging this pull request may close these issues.

List comprehension problem

1 participant

@krassowski