fixed #2067: Reset the option of slider#2068
Closed
PeachScript wants to merge 2 commits intoionic-team:masterfrom
Closed
fixed #2067: Reset the option of slider#2068PeachScript wants to merge 2 commits intoionic-team:masterfrom
PeachScript wants to merge 2 commits intoionic-team:masterfrom
Conversation
Reset the option that continuous of slider when I updated it
|
I think this commit will force all slideBoxes into continuous mode if they have more than 2 slides. (Even slideBoxes that were not meant to be continuous.) Either way, I think this is a duplicate of #1891 |
Author
|
You're right, I make some mistakes in this commit, I will correct them as soon as possible, thank you every much! And please close the issue if you did not found the problem after testing, but my project really has the problem, maybe I caused the problem in my project. |
Contributor
|
Not relevant with the slidebox refactor that just landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset the option that continuous of slider when I updated it