Skip to content

fix(messaging, ios): revert "fix(messaging, ios): only call onMessage handler if message is data-only or undelivered" - #5641

Merged
mikehardy merged 2 commits into
masterfrom
revert-5604-helenaford/fix-on-message-event
Aug 24, 2021
Merged

fix(messaging, ios): revert "fix(messaging, ios): only call onMessage handler if message is data-only or undelivered"#5641
mikehardy merged 2 commits into
masterfrom
revert-5604-helenaford/fix-on-message-event

Conversation

@helenaford

@helenaford helenaford commented Aug 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #5604

From additional testing, fixes the duplication issue but causes another issue where apple throttle willPresentNotification with the presence of mutableContent in the payload

I will be pursuing other solutions as the duplicate notification bug causes a big issue in apps

@vercel

vercel Bot commented Aug 24, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/5yDZ7JLgr4qgx53FFN5XeyZptuCG
✅ Preview: https://react-native-firebase-git-revert-5604-helenafo-6e74d2-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/EryEqDeAtJyTYEBsBSGknK3bsk7X
✅ Preview: Canceled

@codecov

codecov Bot commented Aug 24, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5641 (62e9c84) into master (73208c8) will not change coverage.
The diff coverage is n/a.

❗ Current head 62e9c84 differs from pull request most recent head 7a8715e. Consider uploading reports for the commit 7a8715e to get more accurate results

@@            Coverage Diff            @@
##             master    #5641   +/-   ##
=========================================
  Coverage     53.65%   53.65%           
  Complexity      632      632           
=========================================
  Files           208      208           
  Lines         10084    10084           
  Branches       1543     1543           
=========================================
  Hits           5410     5410           
  Misses         4391     4391           
  Partials        283      283

mikehardy
mikehardy approved these changes Aug 24, 2021
View reviewed changes

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed under: no good deed unpunished

@mikehardy mikehardy changed the title Revert "fix(messaging, ios): only call onMessage handler if message is data-only or undelivered" fix(messaging, ios): revert "fix(messaging, ios): only call onMessage handler if message is data-only or undelivered" Aug 24, 2021
@mikehardy
mikehardy merged commit f2162b7 into master Aug 24, 2021
@mikehardy
mikehardy deleted the revert-5604-helenaford/fix-on-message-event branch August 24, 2021 22:53
@lnuvy lnuvy mentioned this pull request Aug 27, 2026
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@helenaford @mikehardy