Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: invertase/react-native-firebase
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v21.4.1
Choose a base ref
...
head repository: invertase/react-native-firebase
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v21.5.0
Choose a head ref
  • 8 commits
  • 70 files changed
  • 3 contributors

Commits on Nov 14, 2024

  1. feat(firestore): implement sum() & average() aggregate queries (#…

    …8115)
    
    * feat(firestore): support for aggregate queries including `sum()` & `average()`
    * feat(firestore, android): working version of aggregate query
    * feat: iOS implementation of aggregate queries
    * test: getAggregateFromServer()
    * test: update e2e tests
    * chore: improve typing
    * chore: format
    * chore: rm assertions
    * chore: format
    * feat: 'other' platform support
    * tes: fix test scopes
    * fix: firestore lite has different name for API
    * test: ensure exposed to end user
    * test: fix broken tests
    * fix(android): allow null value for average
    * chore: fix typo
    * fix(firestore, android): send null errors through promise reject path
    having native module exceptions vs promise rejects requires JS level
    code to handle multiple types of error vs being able to use one style
    * test: update aggregate query to see what happens with float handling
    * fix: update exception handling iOS
    * chore: AggregateQuerySnapshot type update
    * fix: return after promise rejection
    * fix: android, fieldPath can be null for count. fix promise.reject
    * chore: remove tag
    * test: edge cases for aggregate queries
    * chore: remove only() for test
    * test: update what test produces
    * test: correct return type expected
    * test: ensure aggregate fields are exposed to end user
    
    ---------
    
    Co-authored-by: Mike Hardy <github@mikehardy.net>
    russellwheatley and mikehardy authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e4c57fa View commit details
    Browse the repository at this point in the history
  2. fix(app-check, ios): remove import loop to fix protocol def warning

    import loops can apparently be the root cause of protocol definition issues,
    and if you ensure imports only happen once by chaining correctly then protocol
    definitions are found correctly and the warning goes away
    mikehardy committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    789d41b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Configuration menu
    Copy the full SHA
    dd979a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. fix(android): rn74 forward-port onCatalystInstanceDestroy -> invalidate

    onCatalystInstanceDestroy is no longer calld as of rn74, so our teardown
    methods were not being called so we were orphaning listeners on rn 74+
    
    this forward ports to the new invalidate API for rn74+ but leaves in place
    the old hook as an override for people on rn73- and just delegates to the new
    implementation
    mikehardy committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    83696ea View commit details
    Browse the repository at this point in the history
  2. fix(android): forward-port to non-deprecated data collection API

    available since 2020, so should have no affect on consumers
    mikehardy committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    2c87eeb View commit details
    Browse the repository at this point in the history
  3. style(lint): ignore two discouraged api lints

    one is never used apparently but shouldn't be removed in case
    brownfield apps are using it as it is public static
    
    the other is required in order to support resource load by name
    functionality for remote config
    mikehardy committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    2fb44ba View commit details
    Browse the repository at this point in the history
  4. test(android): enable gradle deprecation warnings, fix jacoco depreca…

    …tion
    
    this prepares the e2e app for gradle 9
    mikehardy committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    efcee60 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ca6b846 View commit details
    Browse the repository at this point in the history
Loading