JCL-367: Distinguish between creator and recipient in access credential queries #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSeydoux
approved these changes
Jun 2, 2023
Contributor
There was a problem hiding this comment.
Tests referencing the notion of Agent (e.g. testQueryGrantAgent) could be renamed to the appropriate role, i.e. Recipient or Creator.
Collaborator
Author
There was a problem hiding this comment.
That's a very good idea. I'll create a ticket to make that adjustment in the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the
AccessGrantClient.query()method has anagentparameter, which refers to the recipient of an access credential, but there is no way to query based oncreator. This PR introduces an additional parameter so that one can query for creator and/or recipient.Note: this also moves the
resourceURI to the first position in the new::queryAPI (to be introduced in Beta3), as this property is anticipated to benullless often.