Skip to content

Conversation

@hellikopter
Copy link
Contributor

@hellikopter hellikopter commented May 24, 2023

Changes in PR:

  • new specialized exceptions to cover most common HTTP client errors: 400 Bad Request, 401 Unauthorized, 403 Forbidden, 404 Not Found, 405 Method Not Allowed, 406 Not Acceptable, 409 Conflict, 410 Gone, 412 Precondition Failed, 415 Unsupported Media Type, 429 Too Many Requests, 500 Internal Server Error
  • SolidClient throws specialized exceptions whenever applicable

@hellikopter hellikopter changed the title JCL-309: Create and use specific HTTP exceptions JCL-309: Add specific HTTP exceptions May 24, 2023
@hellikopter hellikopter changed the title JCL-309: Add specific HTTP exceptions JCL-309: Specialized HTTP exceptions May 24, 2023
@hellikopter hellikopter marked this pull request as ready for review May 24, 2023 11:15
@hellikopter hellikopter requested a review from a team as a code owner May 24, 2023 11:15
@hellikopter hellikopter changed the title JCL-309: Specialized HTTP exceptions JCL-309: Specialized HTTP client exceptions May 24, 2023
hellikopter and others added 13 commits May 24, 2023 13:08
…n.java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
…java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
….java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
…rException.java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
…ception.java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
…java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
…tion.java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
…Exception.java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
…eption.java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
…ion.java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
…peException.java

Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Copy link
Collaborator

@acoburn acoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellikopter hellikopter enabled auto-merge (squash) May 24, 2023 12:51
@hellikopter hellikopter merged commit 2795de9 into main May 24, 2023
@hellikopter hellikopter deleted the JCL-309_specific_exceptions branch May 24, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants