JCL-361: Make it easier to modify Access Control resources #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
472eec8 to
c4b993c
Compare
c4b993c to
7f70450
Compare
NSeydoux
approved these changes
Jun 1, 2023
| final Set<String> supportedTypes; | ||
| if (AccessGrant.class.isAssignableFrom(clazz)) { | ||
| type = ACCESS_GRANT; | ||
| type = URI.create("SolidAccessGrant"); |
Contributor
There was a problem hiding this comment.
For my own understanding, in this case where the given string isn't a URI, what does the constructor do?
Collaborator
Author
There was a problem hiding this comment.
This is a relative URI. Perfectly valid
|
|
||
| // Access Control Resource | ||
| final IRI subject = asIRI(acl); | ||
| triples.add(rdf.createTriple(subject, a, asIRI(ACP.AccessControlResource))); |
Contributor
There was a problem hiding this comment.
Is this triple necessary? I assumed this type would be present by default in the ACR.
Collaborator
Author
There was a problem hiding this comment.
In the Inrupt implementation, none of the type triples are strictly necessary. That said, a different impl may require them. Furthermore, the ACR for a resource may be empty, in which case the triple will not already be present.
In short: it never hurts to be explicit, and there may be cases where it is necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a utility function to make it easier to modify Access Control resources to support AccessGrants.
Eventually, this will become part of a stand-alone ACP module, but adding full support for ACP is beyond the scope of the 1.0 release. This, however, allows developers to interact more easily with ACRs within the 1.0 release timeframe.
A sample usage of this would be: