Skip to content

JCL-342: Use correct data subject property for access requests #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timea-solid merged 2 commits into from
May 9, 2023
Merged

JCL-342: Use correct data subject property for access requests #446

timea-solid merged 2 commits into from
May 9, 2023

Conversation

@acoburn
Copy link
Collaborator

@acoburn acoburn commented May 8, 2023

The AccessRequest data model uses the property isConsentForDataSubject, as described in the documentation.

This changes the generation of an access request to follow that structure.

@acoburn acoburn requested a review from a team as a code owner May 8, 2023 22:24
@acoburn acoburn temporarily deployed to ESS PodSpaces May 8, 2023 22:24 — with GitHub Actions Inactive
@acoburn acoburn temporarily deployed to ESS PodSpaces May 8, 2023 22:24 — with GitHub Actions Inactive
@acoburn acoburn temporarily deployed to ESS DevNext May 8, 2023 22:24 — with GitHub Actions Inactive
@timea-solid timea-solid temporarily deployed to ESS PodSpaces May 9, 2023 07:46 — with GitHub Actions Inactive
@timea-solid timea-solid temporarily deployed to ESS PodSpaces May 9, 2023 07:46 — with GitHub Actions Inactive
@timea-solid timea-solid temporarily deployed to ESS DevNext May 9, 2023 07:46 — with GitHub Actions Inactive
@timea-solid
Copy link
Contributor

timea-solid commented May 9, 2023

If I follow correctly, only the Solid Access Request type of grant has this change.

@timea-solid timea-solid merged commit a25dabd into main May 9, 2023
@timea-solid timea-solid deleted the JCL-342-access-request-agent branch May 9, 2023 08:41
@acoburn
Copy link
Collaborator Author

acoburn commented May 9, 2023

If I follow correctly, only the Solid Access Request type of grant has this change.

This is correct. The Access Grant type uses the existing properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timea-solid timea-solid timea-solid approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@acoburn @timea-solid