JCL 339: Upgrade JsonB module to use Jakarta EE 10 #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoburn
approved these changes
May 1, 2023
Collaborator
acoburn
left a comment
There was a problem hiding this comment.
LGTM -- I moved the JSON-API dependency to 2.1.1 (newer) and separated that version management from the glassfish implementation dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change
<jakarta.json.version>from 1.1.6 to 2.0.1 (which was the most recent and popular version that didn't cause conflicts). This wasn't explicitly mentioned in the ticket but the packagejakarta.json.JsonExceptionwasn't recognised in 1.1.6. Would appreciate any feedback as I'm unsure which version would be most appropriate.