JCL-476: Adjust ProblemDetails API #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSeydoux
reviewed
Jul 3, 2024
| try (final InputStream input = new ByteArrayInputStream(body)) { | ||
| final Data pdData = jsonService.fromJson(input, Data.class); | ||
| final URI type = Optional.ofNullable(pdData.type) | ||
| .map(uri::resolve) |
Contributor
There was a problem hiding this comment.
The same is required for the instance URI
Collaborator
Author
There was a problem hiding this comment.
|
SonarQube Quality Gate
|
NSeydoux
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three significant changes to the ProblemsDetails API in this PR:
ProblemDetails::getDetailsbecomesProblemDetails::getDetail. This aligns the implementation with the RFCProblemDetails.DEFAULT_TYPEvalue is now aURI(instead of aString)SolidClientException::fromErrorResponsehas been refactored.InputStreamis now handled in a try-with-resources block to prevent resource leakageURIso that any relativeURIs in theProblemDetailsbody can be resolved correctlyIn addition, the compiler arguments are changed from the old-style
maven.compiler.source/maven.compiler.targetto the new approachmaven.compiler.release. This eliminates a troublesome compiler warning.