Skip to content

Std. atrribute filtering and faceting support in client #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anithakathir wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Std. atrribute filtering and faceting support in client #20

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e9d53cc
Add support for filtering by product attributes
anithakathir Feb 17, 2017
0eba062
Adds support for faceting by product attributes
anithakathir Feb 17, 2017
8b65d23
Update SearchResult to include AttributeFacets
anithakathir Feb 17, 2017
1b52655
Extracting out the std. attributes impl details
anithakathir Feb 20, 2017
57e2b3b
Merge branch 'master' into support-attr-filters-facets
anithakathir Feb 24, 2017
fb35aca
Remove std attribute specifics while faceting
anithakathir Feb 27, 2017
2b7a25e
Bump up client version and add feature usage in README
anithakathir Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove std attribute specifics while faceting
  • Loading branch information
@anithakathir
anithakathir committed Feb 27, 2017
commit fb35aca0580a4933ba8df08d155eec5c0ed41e07
3 changes: 1 addition & 2 deletions src/main/java/com/indix/query/SearchQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ public SearchQuery withCategoryId(List<Integer> categoryId) {
/**
* Combined with any of query/brand/category/store, limits results to products with specific attribute values
* NOTE:
* Prepends attribute filter key with "attr.", since product attributes are identified that way.
* Examples of a few product attribute keys and values are:
* 1. color -> red / blue / green / black
* 2. size -> xs / s / m / l / xl
Expand Down Expand Up @@ -237,7 +236,7 @@ public SearchQuery withFacetBy(List<String> facetBy) {
*/
public SearchQuery withAttrFacetBy(List<String> attrFacetBy) {
for (String attrFacet : attrFacetBy) {
parameters.add(new BasicNameValuePair("attrFacetBy", attrFacet));
parameters.add(new BasicNameValuePair("attrFacetBy", "attr."+attrFacet));
}
return this;
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/indix/query/SearchQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void testBasicQuery() {
.withSku("sku1")
.withSortBy(SearchQuery.SortBy.PRICE_HIGH_TO_LOW)
.withFacetBy(Arrays.asList("storeId", "brandId"))
.withAttrFacetBy(Arrays.asList("attr.color", "attr.size"))
.withAttrFacetBy(Arrays.asList("color", "size"))
.withAttrFilter("color", Arrays.asList("black", "red"))
.withAttrFilter("size", Arrays.asList("xs"))
.withPageNumber(5)
Expand Down