helium/ui: improve automatic Picture-in-Picture behavior#1765
Open
firatciftci wants to merge 11 commits into
Open
helium/ui: improve automatic Picture-in-Picture behavior#1765firatciftci wants to merge 11 commits into
firatciftci wants to merge 11 commits into
Conversation
…endence and fullscreen space support
…ing and activation checks
…to PiP functionality
|
Reviews (1): Last reviewed commit: "helium/ui: rename patch file" | Re-trigger Greptile |
|
This is really interesting I installed the PiP extension and its already doing it automatically for me Helium Version 0.12.3.1 |
Author
|
@okseb it handles the case of automatically invoking PiP when switching tabs, but (at least on my end) it's not handling the case of switching to another application or switching between multiple macOS spaces. There's also the case of PiP not showing up in non-desktop spaces too, alongside the forced safety margin Chromium adds around PiP (i.e., not letting it be flush with the screen's edge) that this PR is tackling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your pull request to not get closed without review, please confirm that:
Tested on (check one or more):
This PR improves automatic Picture-in-Picture behavior so a playing video can enter PiP when its browser window loses focus, not only when the user switches tabs. The auto-PiP observer now also tracks browser activation, so a selected tab is treated as inactive for auto-PiP purposes when its containing browser is no longer the active browser. I've also adjusted things so that we keep auto-PiP from triggering when focus moves to another external display; on macOS, the display check uses the actual frontmost application window instead of global window ordering, which avoids suppressing PiP incorrectly during same-display Space switches.
Finally, this removes Chromium’s default PiP edge buffer so the PiP window can sit flush against the screen edge when restored near an edge. On macOS, the PiP window is also marked as eligible for existing fullscreen Spaces, so it can appear over native fullscreen apps instead of only regular desktop Spaces.
This makes auto-PiP work in common multitasking cases such as:
I've also added a new new Appearance setting toggle, so users can disable focus-loss auto-PiP without disabling Chromium’s existing tab-switch auto-PiP behavior.
Related issues: