Change document visibility check to be UA choice - #1067
Merged
Manishearth merged 1 commit intoMay 29, 2020
Conversation
Contributor
Author
Contributor
Author
|
FWIW my read of what was discussed during the meeting was that folks were okay with removing it entirely. |
|
I think let's remove it entirely |
Contributor
Author
|
Alright, gonna change the PR |
Manishearth
force-pushed
the
document-visibility
branch
from
May 29, 2020 16:22
ace88ea to
896e1ea
Compare
Contributor
Author
|
Updated PR, old commit can be found at Manishearth@ace88ea |
toji
approved these changes
May 29, 2020
toji
left a comment
Member
There was a problem hiding this comment.
LGTM. This was my understanding of the consensus on the last call as well.
Contributor
Author
|
In that case I'll merge. There certainly wasn't any opposition to this approach in the call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm also open to removing it entirely, there seemed to be general consensus that
visibilityStateis enough.Fixes #1041
Preview | Diff