The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed in php 8.6 (master) #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call zval_ptr_dtor_nogc() directly instead
Member
|
Well that failed spectacularly. :) |
Author
|
@tricky none of failures seems to be related to my changes. looks like missing slash in action somewhere, at least for linux builds |
|
It is an invalid redirect location got from secure.php.net for the distribution archive |
Member
|
Yes, hence the smiley. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Tried building against php master branch and this issue jumped out.
php UPGRADING.INTERNALS says: "The zval_dtor() alias of zval_ptr_dtor_nogc() has been removed. Call zval_ptr_dtor_nogc() directly instead.".
So as this is purely removed alias, this seems to be a trivial fix